Add local fetch caching to cvd fetch
#542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjreynol
force-pushed
the
local-fetch-caching
branch
4 times, most recently
from
8a02ea0
to
c2d35db
Compare
|
The first commit with |
cjreynol
requested review from
Databean,
jemoreira,
rmuthiah,
jmacnak and
adelva1984
as code owners
|
@jemoreira please review when you have a chance :) |
Databean
reviewed
May 8, 2024
jemoreira
reviewed
May 9, 2024
cjreynol
force-pushed
the
local-fetch-caching
branch
9 times, most recently
from
6f86966
to
2948b62
Compare
Databean
reviewed
May 17, 2024
Databean
reviewed
May 17, 2024
Databean
approved these changes
May 17, 2024
IFF the `--target_directory` and `/tmp/cvd/<user_id>/cache` can be hardlinked, repeated `cvd fetch` commands on the same build+target will reference cached files and hardlink the files to the target directory for use. The extract and renaming steps still occur every time, this is only caching for downloads against AB. This new behavior is on by default (`--enable_caching=true`). Test: cvd fetch --target_directory=/tmp/cvd/fetch_test --default_build=11801630 Test: ls /tmp/cvd/<user_id>/cache/11801630/aosp_cf_x86_64_phone-trunk_staging-userdebug/ Test: # repeat fetch command and review `fetch.log` to see the archive downloads do not happen
cjreynol
force-pushed
the
local-fetch-caching
branch
from
2948b62
to
4130991
Compare
jrguzman-ms
pushed a commit
to msft-mirror-aosp/device.google.cuttlefish
that referenced
this pull request
May 29, 2024
Tested over in google/android-cuttlefish#542, but committing here for the eventual migration. Bug: 337940247 Test: m Change-Id: Id5adbb6a82a530722ee6e411a186e07d54399dee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IFF the
--target_directoryand/tmp/cvd/<user_id>/cachecan behardlinked, repeated
cvd fetchcommands on the same build+target willreference cached files and hardlink the files to the target directory
for use.
The extract and renaming steps still occur every time, this is only
caching for downloads against AB.
This new behavior is on by default (
--enable_caching=true).Test: cvd fetch --target_directory=/tmp/cvd/fetch_test
--default_build=11801630
Test: ls
/tmp/cvd/<user_id>/cache/11801630/aosp_cf_x86_64_phone-trunk_staging-userdebug/
Test: # repeat fetch command and review
fetch.logto see the archivedownloads do not happen