Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pycolmap documentation from rmbrualla to trueprice. #118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

humberthardy
Copy link

In the documentation, it is mentioned that we can use fisheye camera model, but you probably forgot to mention that we should use another version of pycolmap, trueprice, because:

  1. rmbrualla does not support OPENCV_FISHEYE camera model
  2. rmbrualla's commits has been already merged to trueprice (-rmbrualla is a fork of trueprice-)
    --
    Tip for testers: do not forgot to update the Config.near if you are using a fisheye camera ;)

@google-cla
Copy link

google-cla bot commented May 2, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hecodeit
Copy link

In the documentation, it is mentioned that we can use fisheye camera model, but you probably forgot to mention that we should use another version of pycolmap, trueprice, because:

  1. rmbrualla does not support OPENCV_FISHEYE camera model
  2. rmbrualla's commits has been already merged to trueprice (-rmbrualla is a fork of trueprice-)

    Tip for testers: do not forgot to update the Config.near if you are using a fisheye camera ;)

@humberthardy
If using OPENCV_FISHEYE, what's the value of Config.near should setting?

@humberthardy
Copy link
Author

@hecodeit: I notice we had a kind of "sphere removal" with fisheye around the camera (like the teleporter in terminator).
My pictures were not blurred, so I used a value close to 0 (0.001 if I remember well)

1 similar comment
@humberthardy
Copy link
Author

humberthardy commented Aug 17, 2023

@hecodeit: I notice we had a kind of "sphere removal" with fisheye around the camera (like the teleporter in terminator).
My pictures were not blurred, so I used a value close to 0 (0.001 if I remember well)

@hecodeit
Copy link

Thanks @humberthardy, I'll try 0.001

I notice NerfStudio most dataset use fisheye lens, and the near plan setting using 0.05, maybe try 0.05 both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants