kconfig: re-organize Kconfig symbols for menuconfig #494
Conversation
|
Visit the preview URL for this PR (updated for commit cee18ef): https://golioth-firmware-sdk-doxygen-dev--pr494-szczys-reorg-k-glx7m0vh.web.app (expires Tue, 28 May 2024 22:49:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Code Coverage
|
port/zephyr/Kconfig
Outdated
|
|
||
| menu "CoAP" | ||
|
|
||
| config LIBCOAP_TLS_HOSTNAME_LEN_MAX |
There was a problem hiding this comment.
Is this used by the Zephyr port?
There was a problem hiding this comment.
Good call, I added a commit before this one to remove the unused symbol.
src/Kconfig.coap
Outdated
| Maximum length of a CoAP path (everything after | ||
| "coaps://coap.golioth.io/"). | ||
|
|
||
| config GOLIOTH_LIBCOAP_EXTRA_FDS_MAX |
There was a problem hiding this comment.
Should we move this to somewhere in the port/ folder? So it only shows up for ports that are using libcoap.
There was a problem hiding this comment.
I grepped the SDK and I don't see this symbol referenced anywhere else. I think it's a leftover from when we used libcoap with Zephyr so I removed it along with the symbol mentioned in the comment above. (This removal was done in a separate commit from the reorg work).
szczys
force-pushed
the
szczys/reorg-kconfig
branch
from
4ee8ca4
to
f634ab6
Compare
Remove symbols that were added for the libcoap-version of Zephyr support but are no longer needed now that we use Zephyr-native coap - LIBCOAP_TLS_HOSTNAME_LEN_MAX - GOLIOTH_LIBCOAP_EXTRA_FDS_MAX Signed-off-by: Mike Szczys <[email protected]>
Break Kconfig symbols out into files that group them by type. Update the Zephyr and ESP-IDF Kconfig files to include the various new Kconfig groups into menus for better presentation in menuconfig. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/reorg-kconfig
branch
from
f634ab6
to
cee18ef
Compare
Break Kconfig symbols out into files that group them by type. Update the Zephyr Kconfig to include the various new Kconfig groups into menus for better presentation in menuconfig.
resolves https://github.com/golioth/firmware-issue-tracker/issues/571