lightdb: require content type when registering an observation #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczys
requested review from
sam-golioth,
mniestroj,
rashmivaidya72 and
hasheddan
|
Visit the preview URL for this PR (updated for commit 32c227d): https://golioth-firmware-sdk-doxygen-dev--pr493-szczys-lightdb-8agzixd3.web.app (expires Wed, 29 May 2024 21:39:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Code Coverage
|
sam-golioth
approved these changes
May 20, 2024
| @@ -395,7 +395,11 @@ static void test_lightdb_invalid(struct golioth_client *client) | |||
|
|
|||
| static void test_lightdb_observe_setup(struct golioth_client *client) | |||
| { | |||
| golioth_lightdb_observe_async(client, "hil/lightdb/observed/int", int_cb, NULL); | |||
| golioth_lightdb_observe_async(client, | |||
There was a problem hiding this comment.
Let's add a test for CBOR observations too
There was a problem hiding this comment.
I've added a commit to test both CBOR and JSON observation types.
Allow user to specify the LightDB State serialization format returned by the server when an observation is registerd. Prior to this change, JSON was being used by default while the server is also capable of returning CBOR. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/lightdb_observe_use_content_type
branch
from
8daffa7
to
e86f740
Compare
Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/lightdb_observe_use_content_type
branch
from
e86f740
to
32c227d
Compare
sam-golioth
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to specify the LightDB State serialization format returned by the server when an observation is registerd. Prior to this change, JSON was being used by default while the server is also capable of returning CBOR.