Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP-IDF Stream Example #395

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

rashmivaidya72
Copy link
Contributor

NOTE: The Zephyr LightDB Stream example uses the struct sensor_value from the Zephyr SDK. As this structure is not available outside of Zephyr, I have included its definition in the ESP-IDF example. Also, the Zephyr Example allows for obtaining temperature values directly from a temperature sensor if the platform supports it. However, the ESP-IDF example always generates fake temperature values.

Copy link

github-actions bot commented Mar 13, 2024

Visit the preview URL for this PR (updated for commit 0ee9d5e):

https://golioth-firmware-sdk-doxygen-dev--pr395-rsv-espidf-lig-ccdu6wlb.web.app

(expires Wed, 29 May 2024 18:52:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9993e61697a3983f3479e468bcb0b616f9a0578

examples/esp_idf/lightdb_stream/README.md Outdated Show resolved Hide resolved
examples/esp_idf/lightdb_stream/README.md Outdated Show resolved Hide resolved
examples/esp_idf/lightdb_stream/main/app_main.c Outdated Show resolved Hide resolved
@rashmivaidya72 rashmivaidya72 force-pushed the rsv/espidf_lightdb_stream_example branch from 3797e5c to 51b6498 Compare March 18, 2024 23:58
@rashmivaidya72 rashmivaidya72 force-pushed the rsv/espidf_lightdb_stream_example branch 2 times, most recently from 715409f to 8a8cf34 Compare March 25, 2024 17:04
@sam-golioth
Copy link
Contributor

@rashmivaidya72
Copy link
Contributor Author

@rashmivaidya72 The lightdb stream sample test failed on the esp32s3: https://github.com/golioth/golioth-firmware-sdk/actions/runs/8424019673/job/23067520531?pr=395

@sam-golioth This seems to be a timing issue. The test expects 20.0, but the DUT has already published 20.0 and 20.5, causing the assertion to fail.
FAILED examples/esp_idf/lightdb_stream/pytest/test_sample.py::test_lightdb_stream - assert 20.5 == 20.0

If I remove the check for Golioth client connected, the test speeds up and the assertion succeeds.

Copy link

github-actions bot commented Mar 27, 2024

Code Coverage

Type Coverage
lines 58.7% (1259 of 2145 lines)
functions 65.8% (125 of 190 functions)

@sam-golioth
Copy link
Contributor

We need to rebase this PR and fix the failing CI tests.

@rashmivaidya72 rashmivaidya72 force-pushed the rsv/espidf_lightdb_stream_example branch 3 times, most recently from a8d44ee to 05e7941 Compare April 3, 2024 22:33
@sam-golioth
Copy link
Contributor

@rashmivaidya72 rashmivaidya72 force-pushed the rsv/espidf_lightdb_stream_example branch from 05e7941 to 53fa0f6 Compare April 9, 2024 21:58
@rashmivaidya72 rashmivaidya72 marked this pull request as draft April 10, 2024 22:45
@rashmivaidya72 rashmivaidya72 force-pushed the rsv/espidf_lightdb_stream_example branch from 53fa0f6 to 1062729 Compare April 11, 2024 01:13
@rashmivaidya72 rashmivaidya72 force-pushed the rsv/espidf_lightdb_stream_example branch from 1062729 to 8eec5d6 Compare May 16, 2024 14:32
@sam-golioth sam-golioth force-pushed the rsv/espidf_lightdb_stream_example branch 3 times, most recently from 3b48f24 to 5a5e334 Compare May 22, 2024 02:52
@sam-golioth sam-golioth marked this pull request as ready for review May 22, 2024 02:52
@sam-golioth sam-golioth changed the title ESP-IDF LightDB Stream Example ESP-IDF Stream Example May 22, 2024
@sam-golioth sam-golioth force-pushed the rsv/espidf_lightdb_stream_example branch 2 times, most recently from 76e0b0e to 7bc8762 Compare May 22, 2024 03:03
@sam-golioth
Copy link
Contributor

@mniestroj @szczys This one is ready for a review

@sam-golioth sam-golioth requested review from sam-golioth and removed request for sam-golioth May 22, 2024 03:54
examples/esp_idf/stream/README.md Outdated Show resolved Hide resolved
examples/esp_idf/stream/README.md Outdated Show resolved Hide resolved
examples/esp_idf/stream/README.md Outdated Show resolved Hide resolved
examples/esp_idf/stream/README.md Outdated Show resolved Hide resolved
examples/esp_idf/stream/README.md Outdated Show resolved Hide resolved
examples/esp_idf/stream/main/app_main.c Outdated Show resolved Hide resolved
examples/esp_idf/stream/main/app_main.c Outdated Show resolved Hide resolved
examples/esp_idf/stream/main/app_main.c Outdated Show resolved Hide resolved
examples/esp_idf/stream/main/app_main.c Outdated Show resolved Hide resolved
examples/esp_idf/stream/pytest/test_sample.py Outdated Show resolved Hide resolved
@sam-golioth sam-golioth force-pushed the rsv/espidf_lightdb_stream_example branch from 7bc8762 to a02554c Compare May 22, 2024 18:46
Signed-off-by: Rashmi Vaidya <[email protected]>
Signed-off-by: Sam Friedman <[email protected]>
@sam-golioth sam-golioth force-pushed the rsv/espidf_lightdb_stream_example branch from a02554c to 0ee9d5e Compare May 22, 2024 18:51
@sam-golioth sam-golioth merged commit 7aeffda into main May 23, 2024
37 of 42 checks passed
@sam-golioth sam-golioth deleted the rsv/espidf_lightdb_stream_example branch May 23, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants