-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP-IDF Stream Example #395
Conversation
Visit the preview URL for this PR (updated for commit 0ee9d5e): https://golioth-firmware-sdk-doxygen-dev--pr395-rsv-espidf-lig-ccdu6wlb.web.app (expires Wed, 29 May 2024 18:52:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
3797e5c
to
51b6498
Compare
715409f
to
8a8cf34
Compare
@rashmivaidya72 The lightdb stream sample test failed on the esp32s3: https://github.com/golioth/golioth-firmware-sdk/actions/runs/8424019673/job/23067520531?pr=395 |
@sam-golioth This seems to be a timing issue. The test expects 20.0, but the DUT has already published 20.0 and 20.5, causing the assertion to fail. If I remove the check for Golioth client connected, the test speeds up and the assertion succeeds. |
Code Coverage
|
We need to rebase this PR and fix the failing CI tests. |
a8d44ee
to
05e7941
Compare
Seeing intermittent failures on the CI test: https://github.com/golioth/golioth-firmware-sdk/actions/runs/8546397122/job/23416975750?pr=395#step:7:244 |
05e7941
to
53fa0f6
Compare
53fa0f6
to
1062729
Compare
1062729
to
8eec5d6
Compare
3b48f24
to
5a5e334
Compare
76e0b0e
to
7bc8762
Compare
@mniestroj @szczys This one is ready for a review |
7bc8762
to
a02554c
Compare
Signed-off-by: Rashmi Vaidya <[email protected]> Signed-off-by: Sam Friedman <[email protected]>
a02554c
to
0ee9d5e
Compare
NOTE: The Zephyr LightDB Stream example uses the
struct sensor_value
from the Zephyr SDK. As this structure is not available outside of Zephyr, I have included its definition in the ESP-IDF example. Also, the Zephyr Example allows for obtaining temperature values directly from a temperature sensor if the platform supports it. However, the ESP-IDF example always generates fake temperature values.