Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md section4.8 #1282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md section4.8 #1282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,7 @@ b. [Node.js testing - beyond the basics](https://github.com/testjavascript/nodej

## ![✔] 4.8 Use production-like environment for e2e testing

**TL;DR:** End to end (e2e) testing which includes live data used to be the weakest link of the CI process as it depends on multiple heavy services like DB. Use an environment which is as close to your real production environment as possible like a-continue (Missed -continue here, needs content. Judging by the **Otherwise** clause, this should mention docker-compose)
**TL;DR:** End to end (e2e) testing which includes live data used to be the weakest link of the CI process as it depends on multiple heavy services like DB. Use an environment which is as close to your real production environment as possible like docker-compose set up which ensure (1) An easy way ro run the test by anyone, new developers, CI processes etc... (2) A repeatable and isolated running environment so that the outcome of the tests won’t vary depending from where they were run from, (3) Be as close as possible to the production environment.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**TL;DR:** End to end (e2e) testing which includes live data used to be the weakest link of the CI process as it depends on multiple heavy services like DB. Use an environment which is as close to your real production environment as possible like docker-compose set up which ensure (1) An easy way ro run the test by anyone, new developers, CI processes etc... (2) A repeatable and isolated running environment so that the outcome of the tests won’t vary depending from where they were run from, (3) Be as close as possible to the production environment.
**TL;DR:** End to end (e2e) testing which includes live data used to be the weakest link of the CI process as it depends on multiple heavy services like DB. Use an environment which is as close to your real production environment as possible like docker-compose set up which will ensure:
- An easy way to run the test by anyone, new developers, CI processes etc.
- A repeatable and isolated running environment so that the outcome of the tests won’t vary depending from where they were run from
- Be as close as possible to the production environment


**Otherwise:** Without docker-compose, teams must maintain a testing DB for each testing environment including developers' machines, keep all those DBs in sync so test results won't vary across environments

Expand Down