New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: cleanup crashstack code #67202
Conversation
This patch removes redundant guards for the crash stack feature, as all supported Go architectures now have a crash stack implementation.
This PR (HEAD: 6ff56d6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583416. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
Message from Mauri de Souza Meneguzzo: Patch Set 1: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
Message from Cherry Mui: Patch Set 1: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
Message from Cherry Mui: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-13T15:57:26Z","revision":"808176178782d9c941e995470144330529ea0ad6"} Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
Message from Cherry Mui: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
Message from Dmitri Shuralyov: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583416. |
This patch removes redundant guards for the crash stack feature, as all supported Go architectures now have a crash stack implementation. Change-Id: I7ffb61c57955778d687073418130b2aaab0ff183 GitHub-Last-Rev: 6ff56d6 GitHub-Pull-Request: #67202 Reviewed-on: https://go-review.googlesource.com/c/go/+/583416 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Mauri de Souza Meneguzzo <[email protected]>
This PR is being closed because golang.org/cl/583416 has been merged. |
This patch removes redundant guards for the crash stack feature, as all
supported Go architectures now have a crash stack implementation.