Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the correct file. #3

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Added the correct file. #3

wants to merge 8 commits into from

Conversation

lekha06
Copy link

@lekha06 lekha06 commented Sep 27, 2021

No description provided.

@gohil-jay
Copy link
Owner

It looks like the code is feasible, however there's an issue while executing it. Thus, here's what I recommend:

  • Go to Google Colab
  • Run your code
  • Take a snapshot of executed code
  • Download the Jupyter Notebook (.ipynb file)
  • Upload the file in your forked repo
  • Send a PR here and attach the snapshot with the comment of your PR

This will suffice everything, and I'll merge it after that.

@lekha06
Copy link
Author

lekha06 commented Sep 28, 2021

Okay, will do. Thanks for being patient.

@lekha06 lekha06 closed this Sep 28, 2021
@lekha06 lekha06 reopened this Sep 28, 2021
@lekha06
Copy link
Author

lekha06 commented Sep 28, 2021

Untitled0 ipynb - Colaboratory - Google Chrome 28-09-2021 23_21_27

@gohil-jay
Copy link
Owner

Alright, this code looks good to go! Can you please add the Jupyter notebook to QR Code Generator sub-repo (here) instead of main repo?

Do that, and I'll merge the PR. Thanks for contributing.

@lekha06
Copy link
Author

lekha06 commented Sep 30, 2021

Hi, I added the notebook to the QR code generator :)

@gohil-jay
Copy link
Owner

Hey, I think you again added the wrong file! Please check the same and add the simple ipynb file that you previously added and I approved.

  • Delete the ipynb file from here.
  • Delete the ipynb file here too.
  • Add that same file you deleted in first step here.

After that, send PR, and I'll merge it. [Please make sure you add the correct file]

@gohil-jay gohil-jay self-requested a review October 3, 2021 06:50
Copy link
Owner

@gohil-jay gohil-jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and functionality seems good to go. However, the code file structuring supposed to be followed and the file under sub-repo is incorrect.

Take these steps, and it should be good to go:

  • Delete the ipynb file from here.
  • Delete the ipynb file here too.
  • Delete this original python file as well here.
  • Add that same file you deleted in first step here.
  • After that, send PR, and it'll be merged. [Please make sure you add the correct file]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants