Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS for Redis #19565

Open
wants to merge 100 commits into
base: main
Choose a base branch
from

Conversation

altynbaev
Copy link

@altynbaev altynbaev commented Nov 10, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #13223

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

closes #13223

@MinerYang
Copy link
Contributor

Appreciate @altynbaev ,

We will evaluate this configuration as a candidate of release v2.11 in a more comprehensive way, Please stay tune with us.

Best,
Miner

Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Jan 21, 2024
@OrlinVasilev OrlinVasilev added never-stale Do not stale release-note/update Update or Fix and removed Stale labels Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (3a9d68a) 67.53% compared to head (79f06c2) 45.24%.
Report is 100 commits behind head on main.

❗ Current head 79f06c2 differs from pull request most recent head 148360d. Consider uploading reports for the commit 148360d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19565       +/-   ##
===========================================
- Coverage   67.53%   45.24%   -22.30%     
===========================================
  Files         990      244      -746     
  Lines      109021    13333    -95688     
  Branches     2719     2720        +1     
===========================================
- Hits        73626     6032    -67594     
+ Misses      31432     7002    -24430     
+ Partials     3963      299     -3664     
Flag Coverage Δ
unittests 45.24% <41.37%> (-22.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ability-summary/vulnerability-summary.component.ts 69.23% <100.00%> (+2.56%) ⬆️
...-quotas/project-quotas/project-quotas.component.ts 48.14% <ø> (ø)
...ide-nav/system-robot-accounts/system-robot-util.ts 64.06% <ø> (ø)
src/portal/src/app/services/app-config.ts 100.00% <100.00%> (ø)
...ponents/label-selector/label-selector.component.ts 68.18% <100.00%> (+0.48%) ⬆️
...portal/src/app/shared/services/endpoint.service.ts 15.38% <ø> (ø)
...ortal/src/app/account/sign-in/sign-in.component.ts 53.33% <0.00%> (-0.52%) ⬇️
...ion/create-edit-rule/create-edit-rule.component.ts 35.71% <50.00%> (+0.18%) ⬆️
...n/replication-tasks/replication-tasks.component.ts 49.51% <0.00%> (+0.47%) ⬆️
...em-robot-accounts/new-robot/new-robot.component.ts 21.27% <0.00%> (-0.35%) ⬇️
... and 2 more

... and 749 files with indirect coverage changes

Altynbaev Dinislam and others added 12 commits January 29, 2024 14:38
Signed-off-by: Altynbaev Dinislam <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
* modified label css to allow hover on it

Signed-off-by: Julien Michot <[email protected]>

* modified label css to allow hover on it

Signed-off-by: Julien Michot <[email protected]>

* Update common.scss

Signed-off-by: jmichot-exotec <[email protected]>

* used title way to show full label on hover

Signed-off-by: Julien Michot <[email protected]>

---------

Signed-off-by: Julien Michot <[email protected]>
Signed-off-by: jmichot-exotec <[email protected]>
Co-authored-by: Julien Michot <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
fix: sort Project Quotas

Signed-off-by: Shengwen Yu <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
usage example:
HARBOR_BASE_URL=https://{ip_or_domain}/api/v2.0 RESOURCE=preheat-instance  USER_NAME={username} PASSWORD={password}  python tests/apitests/python/test_permission.py

Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
fixes goharbor#13198

Signed-off-by: stonezdj <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
1. Related issue goharbor#13198

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
1. For goharbor#16517

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
1. Related issue goharbor#19249

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
1. Fixes goharbor#19554

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
…oharbor#19584)

Add audit-log,project,registry,replication API permission testcase

Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
YangJiao0817 and others added 28 commits January 29, 2024 14:38
Fix goharbor#19512

Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Signed-off-by: Liang Zheng <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Bumps [golang.org/x/time](https://github.com/golang/time) from 0.4.0 to 0.5.0.
- [Commits](golang/time@v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: golang.org/x/time
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shengwen YU <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
…or#19766)

Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.2 to 4.5.0.
- [Release notes](https://github.com/golang-jwt/jwt/releases)
- [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md)
- [Commits](golang-jwt/jwt@v4.4.2...v4.5.0)

---
updated-dependencies:
- dependency-name: github.com/golang-jwt/jwt/v4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Altynbaev Dinislam <[email protected]>
…oharbor#19764)

Bumps [github.com/cloudevents/sdk-go/v2](https://github.com/cloudevents/sdk-go) from 2.13.0 to 2.14.0.
- [Release notes](https://github.com/cloudevents/sdk-go/releases)
- [Commits](cloudevents/sdk-go@v2.13.0...v2.14.0)

---
updated-dependencies:
- dependency-name: github.com/cloudevents/sdk-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shengwen YU <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Fix goharbor#19792

Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
)

Bumps gopkg.in/h2non/gock.v1 from 1.0.16 to 1.1.2.

---
updated-dependencies:
- dependency-name: gopkg.in/h2non/gock.v1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shengwen YU <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
…harbor#19763)

Bumps [github.com/go-openapi/runtime](https://github.com/go-openapi/runtime) from 0.19.20 to 0.26.2.
- [Release notes](https://github.com/go-openapi/runtime/releases)
- [Commits](go-openapi/runtime@v0.19.20...v0.26.2)

---
updated-dependencies:
- dependency-name: github.com/go-openapi/runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Shengwen YU <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shengwen YU <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Signed-off-by: Maksym Trofimenko <[email protected]>
Co-authored-by: Maksym Trofimenko <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
fixes goharbor#19429

Signed-off-by: stonezdj <[email protected]>
Co-authored-by: stonezdj <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
remove the unused the part from makefile

Signed-off-by: wang yan <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
* fix artifact page bug

* update testcase

Signed-off-by: Altynbaev Dinislam <[email protected]>
fixes goharbor#19795, remove the noise in the log

Signed-off-by: wang yan <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
* Log ensureArtifact ConflictErr

Signed-off-by: Shuaiyi Liu <[email protected]>

* Log ensureArtifact ConflictErr

Signed-off-by: Shuaiyi Liu <[email protected]>

---------

Signed-off-by: Shuaiyi Liu <[email protected]>
Co-authored-by: Wang Yan <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Signed-off-by: Ha, Son Hai <[email protected]>
Co-authored-by: Ha, Son Hai <[email protected]>
Co-authored-by: MinerYang <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Bumps [kentaro-m/auto-assign-action](https://github.com/kentaro-m/auto-assign-action) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/kentaro-m/auto-assign-action/releases)
- [Commits](kentaro-m/auto-assign-action@v1.2.5...v1.2.6)

---
updated-dependencies:
- dependency-name: kentaro-m/auto-assign-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shengwen YU <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Signed-off-by: shengqiw <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.26.2 to 0.29.0.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.26.2...v0.29.0)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wang Yan <[email protected]>
Co-authored-by: Shengwen YU <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
…rc (goharbor#19810)

Bumps [github.com/vmihailenco/msgpack/v5](https://github.com/vmihailenco/msgpack) from 5.0.0-rc.2 to 5.4.1.
- [Release notes](https://github.com/vmihailenco/msgpack/releases)
- [Changelog](https://github.com/vmihailenco/msgpack/blob/v5/CHANGELOG.md)
- [Commits](vmihailenco/msgpack@v5.0.0-rc.2...v5.4.1)

---
updated-dependencies:
- dependency-name: github.com/vmihailenco/msgpack/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shengwen YU <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
…or#19809)

Bumps [github.com/go-openapi/swag](https://github.com/go-openapi/swag) from 0.22.4 to 0.22.7.
- [Commits](go-openapi/swag@v0.22.4...v0.22.7)

---
updated-dependencies:
- dependency-name: github.com/go-openapi/swag
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shengwen YU <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
feat: support volcEngine replication

Signed-off-by: zhuyuchen.1 <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Habor doesnot support POST /service/token endpoint,
put this request into a transaction will consume
extra database resources and generate many logs.

Signed-off-by: bin liu <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
fmt
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never-stale Do not stale release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Redis TLS