database/gdb: fix #2119 #3559
Open
database/gdb: fix #2119 #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gqcn
requested changes
May 7, 2024
| if t.Kind() != reflect.Struct { | ||
| return []string{} | ||
| } | ||
| return getStructFields(t.Type) |
There was a problem hiding this comment.
这里不能直接改这个基础方法，根据issue描述，似乎是这里没有获取到匿名结构体的Field。这里有一个RecursiveOption的控制你可以研究一下呢？
There was a problem hiding this comment.
@gqcn 这里获取的是最外层结构体，
所以那里是无法获取到Status结构体的字段
There was a problem hiding this comment.
这里不能直接改这个基础方法，根据
issue描述，似乎是这里没有获取到匿名结构体的Field。这里有一个
倒是可以使用gstructs包的其他方法来解析结构体获取所有的字段，当时我看那个方法只有这里使用了，所以就做了改动。
There was a problem hiding this comment.
@gqcn 这里获取的是最外层结构体，
所以那里是无法获取到Status结构体的字段
那截图红框部分没有达到预期，预期是如果内嵌的结构体在没有tag时嵌套结构体的属性会作为Fields返回。可以研究下这个方法为什么失败了呢？
gqcn
requested changes
May 10, 2024
| if t.Kind() != reflect.Struct { | ||
| return []string{} | ||
| } | ||
| return getStructFields(t.Type) |
There was a problem hiding this comment.
@gqcn 这里获取的是最外层结构体，
所以那里是无法获取到Status结构体的字段
那截图红框部分没有达到预期，预期是如果内嵌的结构体在没有tag时嵌套结构体的属性会作为Fields返回。可以研究下这个方法为什么失败了呢？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gstructs.Type.FieldKeys() 无法识别匿名结构体的字段，导致带有With的查询时，查询的字段不符合期望 #2119