enhance: gudp conn feature #3491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldme-git
reviewed
Apr 16, 2024
oldme-git
reviewed
Apr 16, 2024
wln32
reviewed
Apr 29, 2024
| if err == io.EOF { | ||
| return err | ||
| } | ||
| // Still failed even after retrying. |
There was a problem hiding this comment.
这里是不是可以把for循环提出来，第一次调用write没有错误时，直接返回即可，如果有错误，且有retry参数的话，再用for循环尝试发送，这样是不是会好点？
| return err | ||
| } | ||
| // Still failed even after retrying. | ||
| if len(retry) == 0 || retry[0].Count == 0 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.