docs: include authentication example to examples page #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrobin
requested changes
Apr 25, 2024
apps/app/src/app/pages/(examples)/examples/authentication/(authentication).page.ts
Outdated
Show resolved
Hide resolved
apps/app/src/app/pages/(examples)/examples/authentication/(authentication).page.ts
Outdated
Show resolved
Hide resolved
apps/app/src/app/pages/(examples)/examples/authentication/components/form.component.ts
Outdated
Show resolved
Hide resolved
apps/app/src/app/pages/(examples)/examples/authentication/components/form.component.ts
Outdated
Show resolved
Hide resolved
apps/app/src/app/pages/(examples)/examples/authentication/components/form.component.ts
Outdated
Show resolved
Hide resolved
|
Hi @danilolmc sorry I know this has been sitting for a while, was curious if you could rebase the branch so at least the checks can run again. I think you resolved all the previous comments so I'd be happy to see to getting this merged in |
|
Hi @thatsamsonkid, no problem, I'm going to rebase the branch. |
danilolmc
force-pushed
the
docs/auth-example
branch
from
551d9ac
to
13885b5
Compare
|
It's done @thatsamsonkid ! |
apps/app/src/app/pages/(examples)/examples/authentication/(authentication).page.ts
Outdated
Show resolved
Hide resolved
danilolmc
force-pushed
the
docs/auth-example
branch
from
8189353
to
f65e10b
Compare
|
Thanks for your review @thatsamsonkid! Now it's resolved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
The current examples page has very few examples showing what can be done using the spartan/ui library
Closes #241
What is the new behavior?
The examples page now gets an authentication example showcasing
what can be done with spartan/ui, this is a starting point to add more examples to the page similar to shadcn/ui
Does this PR introduce a breaking change?
Other information