Improve UX when falling back between Display Servers #91780
+102
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current UX for DS fallbacks is a bit confusing, as there's quite a bit of (possibly unrelated) errors and then a working game:
Example log from X11 to Wayland
This patchset1 aims to improve the situation where possible, without introducing any big change yet:
From core, we display a warning whenever a fallback is being attempted;
From X11, we alert the user about a failed rendering driver initialization only if it was actually attempted;
From Wayland we actually implement the aforementioned alerts, as they were missing (oops).
New log when falling back from X11 to Wayland
It's not perfect by any means (the DRI_PRIME stuff is especially annoying), but those were some fairly low-hanging fruits and so this will do in the meantime.
Footnotes
Yes, sorry for making three commits but they feel all equally sensitive and unrelated. Please tell me if a single squashed commit is preferred. ↩