Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Migrate Animation from Godot 4.0 to 4.3 article #851

Merged

Conversation

TokageItLab
Copy link
Member

Due to the large number of reworks to the animation feature between 4.0 and 4.3, we are adding an article explaining the options we have added during them.

@TokageItLab TokageItLab marked this pull request as draft May 20, 2024 20:18
@TokageItLab TokageItLab force-pushed the migrate-animation-4-3 branch 2 times, most recently from 56e8f2c to 13b86d6 Compare May 26, 2024 17:54
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love your illustrations so much. They really help set the tone of the blog post. Overall this post is really well made and should help users out a lot!

I have left a lot of grammar suggestions. I tried my best to keep the content the same and maintain your voice as much as possible. Please let me know if any of the suggestions change the meaning of your words or are too different for your comfort.

@TokageItLab TokageItLab force-pushed the migrate-animation-4-3 branch 4 times, most recently from f9ff139 to 67b3e88 Compare May 31, 2024 00:52
@TokageItLab
Copy link
Member Author

@clayjohn Thank you for the huge amount of proofreading! I appreciate very much the use of your time, it is so very helpful :)

I have applied the corrections to the areas @clayjohn pointed out, changed the directory names and fix the text in the images. I am not sure when it would be appropriate to publish this, but I think it would be nice to publish around the time after we launch the 4.3.beta.

@TokageItLab TokageItLab force-pushed the migrate-animation-4-3 branch 3 times, most recently from c4257fc to fe6abad Compare June 2, 2024 22:29
@TokageItLab
Copy link
Member Author

I have added a cover image to #854 as well. It still lacks proofreading, but well no need to publish it on the same day with this article.

@TokageItLab TokageItLab force-pushed the migrate-animation-4-3 branch 2 times, most recently from 2e34a0d to 1b8e4e4 Compare June 4, 2024 12:47
Co-authored-by: Clay John <[email protected]>
Co-authored-by: K. S. Ernest (iFire) Lee <[email protected]>
@coppolaemilio coppolaemilio merged commit 46bb614 into godotengine:master Jun 4, 2024
1 check passed
@coppolaemilio
Copy link
Member

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:blog New blogposts and corrections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants