Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NavigationObstacles for Godot 4.3 changes #9336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented May 6, 2024

Updates NavigationObstacles documentation as they can now affect the navigation mesh baking.

Those changes are only in Godot 4.3 so no need to backport.

Also added an animation for the dynamic obstacles as users had a difficult time to grasp what they do from text alone.

@skyace65 skyace65 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels May 7, 2024
@skyace65 skyace65 added this to the 4.3 milestone May 7, 2024
@@ -377,6 +377,8 @@ source,destination
/tutorials/misc/pausing_games.html,/tutorials/scripting/pausing_games.html
/tutorials/misc/running_code_in_the_editor.html,/tutorials/plugins/running_code_in_the_editor.html
/tutorials/misc/saving_games.html,/tutorials/io/saving_games.html
/tutorials/navigation/navigation_using_navigationobstacles.html#static-obstacles,/tutorials/navigation/navigation_using_navigationobstacles.html#static-avoidance-obstacles
/tutorials/navigation/navigation_using_navigationobstacles.html#static-obstacles,/tutorials/navigation/navigation_using_navigationobstacles.html#dynamic-avoidance-obstacles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea whether anchor links work with redirects. Only one way to find out, I suppose. :)

@mhilbrunner
Copy link
Member

mhilbrunner commented May 7, 2024

Didn't do an in-depth review yet (but trust ATS anyway :)) but this looks good to me so far. I wonder whether we consider 0.8mb OK for the gif - I guess its fine by this day and age? (Maybe @Calinou has opinions or some magic alternative to get it down further?)

@skyace65
Copy link
Contributor

skyace65 commented May 8, 2024

Didn't do an in-depth review yet (but trust ATS anyway :)) but this looks good to me so far. I wonder whether we consider 0.8mb OK for the gif - I guess its fine by this day and age? (Maybe @Calinou has opinions or some magic alternative to get it down further?)

I just tried using Kdenlive but the output ends up being bigger than the original.

@smix8
Copy link
Contributor Author

smix8 commented May 14, 2024

Removed the animation.

Updates NavigationObstacles documentation as they can not affect the navigation mesh baking.
@mhilbrunner mhilbrunner added the content:redirect Issues and PRs involving moving content and adding a redirect rule on the backend label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:redirect Issues and PRs involving moving content and adding a redirect rule on the backend enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants