Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to enable post-import script #9307

Merged
merged 1 commit into from May 14, 2024

Conversation

aXu-AP
Copy link
Contributor

@aXu-AP aXu-AP commented May 1, 2024

Add the step how to enable post-import script in import configurations tutorial.
Page: Import configuration / Using import scripts for automation
The tutorial makes sense if you're reading the whole page (there's mention how import scripts work somewhere on that page), but if you find anchor directly to the section about import scripts, it's missing this crucial bit of information. I actually got stumped for a moment with this, I thought the script has to be added via EditorPlugin or something.

Add the step how to enable post-import script in import configurations tutorial.
@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:import labels May 2, 2024
@AThousandShips AThousandShips requested a review from a team May 2, 2024 09:35
Copy link
Contributor

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

I do wish our documentation would encourage users to develop post-import plugins, which are completely different from post-import scripts. Post import plugins affect the whole project so are much better suited for building workflows and import features rather than one-off scripts

Ideally we would explain the difference between GLTFDocumentExtension, post import plugin, post import script, scene importer and editor resource importers. It's a lot of info and probably aside from me and other import contributors, not things people will even know about

@aXu-AP
Copy link
Contributor Author

aXu-AP commented May 2, 2024

I have never heard about half of those, so maybe their discoverability could be better 😅

@skyace65 skyace65 merged commit 41247a2 into godotengine:master May 14, 2024
1 check passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:import
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants