Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge yet] Add release dates in release notes #966

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arvindsv
Copy link
Member

@arvindsv arvindsv commented Apr 24, 2019

Looks like this:

2019_04_24_19-44-37

Fixes #963

/cc @varshavaradarajan

Dates from: https://github.com/gocd/gocd/releases

@arvindsv
Copy link
Member Author

@varshavaradarajan said it should be done on the downloads page too. Using the date from releases.json. That makes sense. Will do that tomorrow. Don't merge.

@arvindsv arvindsv changed the title Add release dates in release notes [Don't merge yet] Add release dates in release notes Apr 25, 2019
@kritika-singh3
Copy link
Contributor

Ping! pls see if this is still relevant.

@varshavaradarajan
Copy link
Contributor

@kritika-singh3 - I think this can be closed. We added the release date to the downloads page.

@kritika-singh3
Copy link
Contributor

@varshavaradarajan I think the PR was to add the release dates on the release notes. Is it not required anymore?

@varshavaradarajan
Copy link
Contributor

varshavaradarajan commented Dec 4, 2020

Nope. The downloads page makes a call and retrieves the releases.json. Which has the release date, so there is no manual step required. Here, when one edits the release notes, they need to remember and put that in. So, it's overkill. When the release date is already available on the downloads page.

I don't think @arvindsv will do that anymore. :P

@kritika-singh3
Copy link
Contributor

@varshavaradarajan hmm. Agree with your logic.
I'll leave the decision to @arvindsv :)

@chadlwilson chadlwilson marked this pull request as draft October 24, 2021 14:24
@chadlwilson chadlwilson force-pushed the add-release-dates-to-release-notes branch from af440bb to 06bcd36 Compare October 20, 2022 15:20
@chadlwilson chadlwilson force-pushed the add-release-dates-to-release-notes branch from 06bcd36 to 457ec12 Compare June 15, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show release date on the downloads page
3 participants