Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

feature: Support the upload of multiple files #2389

Open
wants to merge 2 commits into
base: v1
Choose a base branch
from

Conversation

karlhaas
Copy link

What is being done in this PR?

Supports slices of files in multipart form requests. Fixes #1770

What are the main choices made to get to this solution?

The solution was already suggested here: #1770 (comment)

List the manual test cases you've covered before sending this PR:

In our project we upload several files using the same multi part name "files".

@karlhaas karlhaas requested a review from a team as a code owner November 20, 2023 13:28
@karlhaas
Copy link
Author

@markbates could you please review and merge? The last time it got closed because nobody cares ...

@dammy001
Copy link

dammy001 commented Dec 3, 2023

@markbates could you please review and merge? The last time it got closed because nobody cares ...

any update with this PR? When should we expect this to get reviewed?

@paganotoni
Copy link
Member

@karlhaas @dammy001 I'm not @markbates, but I can look if you want. It looks good to me so far.

@paganotoni paganotoni self-assigned this Dec 3, 2023
@paganotoni paganotoni added the s: in progress Someone is working on this label Dec 3, 2023
@paganotoni
Copy link
Member

paganotoni commented Dec 3, 2023

@karlhaas, some tests are broken. Can you take a look and LMK when those are passing?

@karlhaas
Copy link
Author

karlhaas commented Dec 4, 2023

@paganotoni i removed the check of the file size. Please check thx.

Copy link
Member

@paganotoni paganotoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karlhaas
Copy link
Author

karlhaas commented Dec 7, 2023

@paganotoni could you please merge and release?

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment. Otherwise, this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 22, 2024
@karlhaas
Copy link
Author

@paganotoni who will merge it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
s: in progress Someone is working on this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] How manage multiple upload file in forms?
3 participants