Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/scim: optimize PropertyMapping fetching and execution #9689

Merged
merged 12 commits into from
May 20, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 11, 2024

Details

  • Optimise querying and fetching property mappings for providers which use the outgoing sync framework
  • Compile property mapping expressions once and re-use them
  • Also remove a lot of duplicate code 🎉

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner May 11, 2024 15:34
Copy link

netlify bot commented May 11, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 97b40d4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/664b41781bbdc600083ac298
😎 Deploy Preview https://deploy-preview-9689--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 11, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 97b40d4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/664b41780da96700082582cb
😎 Deploy Preview https://deploy-preview-9689--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 94.85714% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 92.65%. Comparing base (8162c1e) to head (97b40d4).
Report is 2 commits behind head on main.

Files Patch % Lines
authentik/lib/sync/outgoing/base.py 80.00% 5 Missing ⚠️
authentik/sources/ldap/sync/base.py 91.66% 2 Missing ⚠️
authentik/lib/sync/mapper.py 97.14% 1 Missing ⚠️
authentik/sources/ldap/tasks.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9689      +/-   ##
==========================================
+ Coverage   92.54%   92.65%   +0.11%     
==========================================
  Files         707      708       +1     
  Lines       34606    34608       +2     
==========================================
+ Hits        32026    32066      +40     
+ Misses       2580     2542      -38     
Flag Coverage Δ
e2e 49.59% <46.85%> (+0.19%) ⬆️
integration 25.34% <24.00%> (+0.10%) ⬆️
unit 90.10% <94.28%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 13, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-6de80a15851b612699eb1a253f4c5902601e3974
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-6de80a15851b612699eb1a253f4c5902601e3974-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-6de80a15851b612699eb1a253f4c5902601e3974

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-6de80a15851b612699eb1a253f4c5902601e3974-arm64

Afterwards, run the upgrade commands from the latest release notes.

BeryJu added 12 commits May 20, 2024 14:18
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu merged commit 44d7e81 into main May 20, 2024
68 of 69 checks passed
@BeryJu BeryJu deleted the providers/scim/optimize branch May 20, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant