Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sq: rename may cause statistical issue #4316

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

zhangxyue
Copy link
Contributor

When I use simple-quota, I found when file deleted, but fd is not released. Rename may cause statistical issue in this situation.

@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

@aravindavk aravindavk requested a review from amarts March 15, 2024 06:06
@aravindavk
Copy link
Member

@amarts ^^

@aravindavk
Copy link
Member

Please use Fixes: #4315 in the commit. and also use git commit -s (git commit -s --amend to update the commit message)

When I use simple-quota, I found when file deleted, but fd is not released.
Rename may cause statistical issue in this situation.

Fixes: gluster#4315

Signed-off-by: Bruce <[email protected]>
Copy link
Member

@amarts amarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarts
Copy link
Member

amarts commented Mar 17, 2024

/run regression

@gluster-ant
Copy link
Collaborator

1 test(s) failed
./tests/bugs/shard/unlinks-and-renames.t

0 test(s) generated core

3 test(s) needed retry
./tests/basic/distribute/phase1-migration-fops.t
./tests/bugs/glusterd/bug-1696046.t
./tests/bugs/shard/unlinks-and-renames.t
https://build.gluster.org/job/gh_centos7-regression/3383/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants