Fix build system uglienesses and broken make LIBS="-lasan"
#4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Thank you for your contributions. |
Automake has an implicit x = @x@ for every AC_SUBST-ed variable already, stop reinventing the variables -- and enable standard make-time variable overrides. Signed-off-by: Jan Engelhardt <[email protected]>
Why the heck are -lcurlpp -lcryptopp in AM_CPPFLAGS? That variable is not getting used during link anyway, and because of that, there is also no error emitted that I do not have them installed in my OS. Signed-off-by: Jan Engelhardt <[email protected]>
-l must go to LIBADD. Not CFLAGS. And definitely not CPPFLAGS. It's not a preprocessor flag, darn it. -I should preferably go into CPPFLAGS. Signed-off-by: Jan Engelhardt <[email protected]>
Stop trampling on user-defined variables. Move detected required libraries to their own specific variables. Another benefit is that components which do not need one or more of (-lcrypto, -lpthread, -lrt) are not forcibly linked to them. ./configure CFLAGS="-O0 -ggdb3 -fsanitize=address,undefined" && make -j16 LIBS="-lasan -lubsan" Signed-off-by: Jan Engelhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.