This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Check whether peer has devices before removing peer #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signedoff-by: rishubhjain <[email protected]>
ghost
assigned 
|
Fixes : #1422 |
|
Please review, but this should be merged after #1120 |
Madhu-1
suggested changes
Dec 18, 2018
| dev, err := client.DeviceList(g2.PeerID(), "/dev/gluster_loop1") | ||
| r.Nil(err) | ||
| r.Equal(dev[0].Device, "/dev/gluster_loop1") | ||
|
|
||
| err = client.PeerRemove(g2.PeerID()) |
There was a problem hiding this comment.
once the peer remove failed, please remove the device and then try removing the peer again
There was a problem hiding this comment.
I will remove the device once the delete device PR is in. Let's wait for the PR(#1120) to get merged.
| @@ -43,3 +43,11 @@ func (c *Client) DeviceEdit(peerid, device, state string) error { | |||
| err := c.post(url, req, http.StatusOK, nil) | |||
| return err | |||
| } | |||
|
|
|||
| // DevicesInPeer lists devices in peer | |||
| func (c *Client) DevicesInPeer(peerid string) (deviceapi.ListDeviceResp, error) { | |||
There was a problem hiding this comment.
why this is needed?
we already have an API to do this functionality. https://github.com/gluster/glusterd2/blob/master/pkg/restclient/device.go#L26
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.