Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Direction.resolve for rtl #678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

layalk
Copy link

@layalk layalk commented Dec 5, 2023

Currently the Direction.resolve function fails for glide-data-dir="|>" and glide-data-dir="|<".
This fix replaces the < and > in the pattern regardless it's position in the pattern string.

@hseager
Copy link

hseager commented Jan 31, 2024

This would be a great addition to get merged. I've used patch-package until this gets merged and it appears to be working as expected in Arabic and Hebrew. Thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants