Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep component name after minify in build #248

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Sheile
Copy link

@Sheile Sheile commented Feb 28, 2023

After 2.8.3, The component name will be minified by webpack in build.
Therefore, Current version of react-collapsible has following problems.

This PR will resolve it.

1. Component name in React Developer Tools is minified

Until 2.8.0, The component name is Collapsible, but current component name is s after 2.8.3.
IMO, This name may be changed unexpectedly due to changes of webpack behavior and variable name in minification.

image

2. Can't find component in unittest with enzyme

After 2.8.3, following test code will fail. Because component.find('Collapsible') can't find component.

expect(component.find('Collapsible').prop('open')).toBeTruthy()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant