Added a find function to bit_array #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
May 24, 2024
There was a problem hiding this comment.
Hello! Could we have this in the form of split_once please 馃檹
This will also be in the hot path of many applications so we'll need to have the most optimised implementation possible. For Erlang that means using the Erlang standard library implementation. I'm not sure what's best on JavaScript- we'll need to see if the typed array buffer class being used as some method for this.
Thank you! This will be super nice to have and use. 馃挏
test/gleam/bit_array_test.gleam
Outdated
| <<>> | ||
| |> bit_array.find(<<"bar":utf8>>) | ||
| |> should.be_error | ||
| } |
There was a problem hiding this comment.
Let's also have some tests for non-byte aligned bit arrays. These tests would need to have the @target(erlang) attribute as currently the JavaScript target only supports byte aligned bit arrays.
lpil
reviewed
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.