Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] add VS Code Browser release #19746

Merged
merged 6 commits into from
May 16, 2024
Merged

[GHA] add VS Code Browser release #19746

merged 6 commits into from
May 16, 2024

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented May 15, 2024

Description

Related Issue(s)

Fixes ENT-64

How to test

  • Smoke test VS Code Browser with versions are all working well
  • it should generate no changes with cmd below
cd /workspace/gitpod/components/ide/code/gha-update-image/
yarn
bun run index.ts
Editor Stable Code Pinned code (index 0) Pinned code (index -1) latest Code
image image image No worth test it as it's what configured with WORKSPACE.yaml

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=vscode
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link

socket-security bot commented May 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None +2 378 kB types
npm/[email protected] environment 0 671 kB eemeli
npm/[email protected] None 0 667 kB colinmcd94

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

"{{.CodeWebExtensionImage}}",
"{{.CodeHelperImage}}"
"{{.Repository}}/ide/gitpod-code-web:commit-1bc46bd2a58dbc9033313519453939d895f16fce",
"{{.Repository}}/ide/code-codehelper:commit-4cb5b6b9c0e993f3964e978e387fb0e7c1c04276"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes of this file is based on

go install github.com/csweichel/oci-tool@latest
export ref=eu.gcr.io/gitpod-core-dev/build/installer:main-gha.25207
oci-tool fetch file --platform=linux-amd64 $ref app/installer
# chmod +x installer then render a config.yaml

@roboquat roboquat added size/XXL and removed size/XL labels May 15, 2024
@mustard-mh mustard-mh marked this pull request as ready for review May 15, 2024 17:01
@mustard-mh mustard-mh requested a review from a team as a code owner May 15, 2024 17:01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could it just be plain js, don't see the need to introduce another tool that increases maintenance and it's just doing basic stuff like fetch and write to file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That 's because we do it the same for JetBrains' script #19634

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@jeanp413 jeanp413 self-requested a review May 15, 2024 21:59
Copy link
Member

@jeanp413 jeanp413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, did not test the scripts or actions 🙏

@roboquat roboquat merged commit f360aeb into main May 16, 2024
42 of 43 checks passed
@roboquat roboquat deleted the hw/code-gha branch May 16, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants