Update ws-manager-bridge to node 20 reduce logs #19696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the motivation behind this change? Honestly I'd rather not do it, or at least take a real close look into filtering into more detail, just because some of these are our only glimpse into Dedicated cells. 🤔 |
geropl
reviewed
May 2, 2024
| COPY components-ws-manager-bridge--app /installer/ | ||
|
|
||
| WORKDIR /app | ||
| RUN /installer/install.sh | ||
|
|
||
| FROM cgr.dev/chainguard/node:18.17.1@sha256:af073516c203b6bd0b55a77a806a0950b486f2e9ea7387a32b0f41ea72f20886 | ||
| FROM cgr.dev/chainguard/node:20@sha256:f30d39c6980f0a50119f2aa269498307a80c2654928d8e23bb25431b9cbbdc4f |
There was a problem hiding this comment.
This we should do for sure! Did not see it at first due to the log changes.
I would do a quick test in a preview. 👍
There was a problem hiding this comment.
Unless we have a concrete reason, I would not want to update node. Version 18 is supported until next year April.
Also if we do the update we should do it for all our node servers.
There was a problem hiding this comment.
|
I agree with Gero, the logs were helpful yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logs are 100% redacted. We have metrics, and leaving warning and error messages provides better readability.
log sample
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled.