[test] fix integration tests #19692
Merged
[test] fix integration tests #19692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
do-not-merge/work-in-progress
do-not-merge/hold
size/XS
size/S
and removed
size/XS
size/S
labels
15 tasks
Need to give ws-daemon time before it applies process priority
We are not limiting network connections for preview environments
* Regardless of billing mode * If there's an error
kylos101
force-pushed
the
kylos101/gen111-tests
branch
from
4c0dd85
to
bd8ac44
Compare
It was failing with an exit code of 2 on grep, because it was trying to grep a folder, rather than recurse into it. When the grep command was run manually from a workspace that started from a prebuild, we saw `grep: logs: Is a directory`. So, it's important for integration tests to output the exit code, but also error text.
We need to wait for the started workspace to stop, before we try to restart it
aledbf
approved these changes
May 4, 2024
svenefftinge
approved these changes
May 6, 2024
geropl
reviewed
May 6, 2024
Otherwise this returns false: https://github.com/gitpod-io/gitpod/blob/643701c6352609b3bab3090d271d38cb42b33b3c/components/server/src/billing/billing-mode.ts#L25 Because EnablePayment is set to false at install time: https://github.com/gitpod-io/gitpod/blob/643701c6352609b3bab3090d271d38cb42b33b3c/install/installer/pkg/components/server/configmap.go#L282
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few tests have been consistently failing.
server, so that we always limit network connections regardless of billing mode, and to also limit if there was an error inspecting the billing mode.ws-daemontime to apply process priority before asserting priority has been adjusted.grepneeds to be set to explicitly recurse through folders (it was failing on the logs folder). Second, the test wasn't waiting for a workspace to stop, prior to attempting to restart the workspace.Related Issue(s)
Relates to ENT-13
How to test
The tests are green now. After this lands on main, we'll need to trigger a manual run with the updated main-gha asset. Why? We only test the last successful build of main-gha when testing, and the tests passing are considered part of the success.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold