Deal with clipboard permission issues #19687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gh run recreate-vm=true Chat ops job failed. See 8896089805 for details |
filiptronicek
commented
Apr 30, 2024
| @@ -16,6 +16,7 @@ export function load(): Promise<{ | |||
| frame.src = startUrl.toString(); | |||
| frame.style.visibility = "visible"; | |||
| frame.className = "gitpod-frame loading"; | |||
| frame.allow = "clipboard-write" | |||
There was a problem hiding this comment.
this fixes the bug with the opening workspace page ssh command copying troubles
svenefftinge
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Writing to the clipboard can throw. We deal with that now.
In addition to that, one needs to allow cross-origin iframes to write to the clipboard, which we did not do and so copying did not work.
Related Issue(s)
Fixes ENT-5 EXP-1737
How to test
Use a Chromium based browser like Chrome, Arc, Brave.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold