Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context missing for test cases #19521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix context missing for test cases #19521

wants to merge 1 commit into from

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Mar 8, 2024

Description

There're some places will print mismatch

  • authorizaer: it's testing mismatch cases
  • organization-service: testing PERMISSION_DENIED / NOT_FOUND (i.e. member update settings, stranger find org)

Important logic change:

  • organization-service: addOrUpdateMember with a new owner it will delete BUILT_IN one from org, add a runWithSubjectId to make sure it's the new owner going to delete the member.
  • workspace-starter: failInstanceStart it can happend no instance (at least in test case)

Others

  • bearer-authxxx.spec.ts: logic of expectError is not complete
  • Test cases to create orgniaztion via BUILT IN users, first joiner should be owner

Related Issue(s)

Fixed [internal chat]

How to test

Check changes of test cases (there're some note for changes on the Description section)

  • Run test in server
  • Should have no error like SubjectId mismatch except what described on PR Description section

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl
Copy link
Member

geropl commented Mar 19, 2024

Sorry @mustard-mh , did manage to overlook this one. Will take a look this afternoon 🙇

Copy link

stale bot commented Apr 22, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 22, 2024
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants