Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] use image digest for redis image #19483

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iQQBot
Copy link
Collaborator

@iQQBot iQQBot commented Feb 28, 2024

Description

[installer] use image digest for redis image

Related Issue(s)

Fixes ENG-1717

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This comment was marked as off-topic.

@iQQBot
Copy link
Collaborator Author

iQQBot commented Mar 1, 2024

@iQQBot
Copy link
Collaborator Author

iQQBot commented Mar 1, 2024

image image

verify image is correct and we can start workspace

@gitpod-io gitpod-io deleted a comment from 31031969 Mar 2, 2024
@gitpod-io gitpod-io deleted a comment from 31031969 Mar 2, 2024
@kylos101
Copy link
Collaborator

kylos101 commented Mar 4, 2024

/hold

wait for https://github.com/gitpod-io/gitpod-dedicated/blob/af8aa69fa964a201c44fa518a55a07c1b00178ed/ops/images/push-images.sh#L21C1-L26C7

Hi @iQQBot , what is left/preventing removal of the hold for this PR? I ask because #19402 landed on Feb 7. I assume there is some other PR or Linear issue or Slack thread remaining. Can you share?

@iQQBot
Copy link
Collaborator Author

iQQBot commented Mar 4, 2024

@kylos101 not all cell upgrade to this version

@kylos101
Copy link
Collaborator

kylos101 commented Mar 4, 2024

@kylos101 not all cell upgrade to this version

Gotcha, thank you, @iQQBot !

@gitpod-io gitpod-io deleted a comment from 31031969 Mar 7, 2024
@gitpod-io gitpod-io deleted a comment from 31031969 Mar 7, 2024
@gitpod-io gitpod-io deleted a comment from 31031969 Mar 7, 2024
Copy link

stale bot commented Mar 17, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 17, 2024
@mustard-mh mustard-mh removed the meta: stale This issue/PR is stale and will be closed soon label Mar 18, 2024
@kylos101 kylos101 added the meta: never-stale This issue can never become stale label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold meta: never-stale This issue can never become stale size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants