-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override network mtu value #1
base: v2
Are you sure you want to change the base?
Conversation
a58a7be
to
091c42e
Compare
It seems like you modified the version to be |
@AaronDewes thank you for mentioning this issue. We are updating docker compose to v2.5.0 in the next deployment and we will fix the semver problem. Apologies for the issue. |
73411c0
to
c6ce2ca
Compare
@aledbf is this still needed? If we're never going to merge, can it be converted to draft? |
We are never going to merge this PR. The idea here is to rebase it after any release from the original repository and update the binary like was being done for the last eight releases. |
9e203ae
to
81854eb
Compare
@aledbf we're a few versions behind on docker compose (2.10.0 -> 2.16.0). I don't have bandwidth to update and test this week, but wanted to check. Are we staying on an older version intentionally? Or should I plan to update as time permits in the future? Cc: @Furisto and @akosyakov for 👀 |
2651a43
to
cc184a2
Compare
@aledbf I am updating our instructions here, also below, to make managing our fork easier. The # of commits is still too high, though. 🤔 What am I doing wrong? Steps I took:
|
3c24ca7
to
7accbf3
Compare
@kylos101 due to the number of changes and being an external repository, I do this:
|
This reverts commit a4ddbcb. Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
When creating automatic file shares, ignore any non-directory bind mounts, e.g. for an individual (normal) file or a special type like a Unix socket (`/var/run/docker.sock`). Additionally, there's no need to create a directory if one does not exist, the API will handle that. However, the check for existence remains so that `create_host_path: false` mounts can be ignored. Signed-off-by: Milas Bowman <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: racequite <[email protected]>
…trl-C on compose up (docker#11719) Ensure done channel is closed only once Signed-off-by: Jaime Soriano Pastor <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
fix support for `--flag=value` syntax in compatibility mode
Signed-off-by: Guillaume Lours <[email protected]>
* `moby/buildkit` commit comes from `docker/buildx` * v26.1-dev from `moby/moby` & `docker/cli` Signed-off-by: Milas Bowman <[email protected]>
Signed-off-by: Guillaume Lours <[email protected]>
This was racy with the sleep, so the Compose file has been tweaked to make it pass reliably. Now, there's 3 services: * `running` - sleeps forever * `exit` - exits _successfully_ immediately * depends on `running` started * `fail` - exits _with error_ immediately * depends on `exit` succeeding Now, the test can ensure that the containers are all run/ started in the expected order the assertions will be reliable. Before, it was possible for `fail` to run & exit before `exit`, for example. The `running` service also ensures there's always at least one other "running" container when we do an abort. Signed-off-by: Milas Bowman <[email protected]>
chore(e2e): fix flaky cascade failure test
Bumps [github.com/moby/buildkit](https://github.com/moby/buildkit) from 0.13.0-rc3.0.20240417151852-71f99c52a669 to 0.13.1. - [Release notes](https://github.com/moby/buildkit/releases) - [Commits](https://github.com/moby/buildkit/commits/v0.13.1) --- updated-dependencies: - dependency-name: github.com/moby/buildkit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…hub.com/moby/buildkit-0.13.1 build(deps): bump github.com/moby/buildkit from 0.13.0-rc3.0.20240417151852-71f99c52a669 to 0.13.1
Do not merge. We only need to rebase the PR after each
docker-compose
release and release a new version.