Fix hang/crash when using --check-databases option for test run
#2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbartol
added
the
Complexity: Low
aeisenberg
reviewed
May 9, 2023
| ); | ||
| // If the user manually adds the `--check-databases` option, we can get events for the | ||
| // corresponding database check tests. Just ignore these for now. | ||
| if (testItem !== undefined) { |
There was a problem hiding this comment.
I think this is fine, but maybe can you add a log message for the unexpected event.test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial fix is to ignore events for tests we didn't explicitly request in the run.
I also discovered that sometimes the CLI emits an empty null-terminated string as an event. We should just ignore those.