-
Notifications
You must be signed in to change notification settings - Fork 58.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenID Connection configuration for Alibaba Cloud #29916
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
Why can't contribute the |
Hope someone can help me. |
@JacksonTian Thanks for your interest in contributing to the Docs and for submitting a PR! ✨ We have built in security checks for any changes made to potentially sensitive files, like the security hardening files you are attempting to change in this PR. They will require an extra review before being considered for acceptance. For future reference, in cases like this where you are adding a new article or guide, we encourage you to open an issue first. That way, we can review the need for your proposed addition before you submit your PR. That will greatly improve the review experience for both sides of the PR. 👍 I'll run this by our team and get it up for review 👀 |
@cmwilson21 Thank you for your feedback. |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
Hello, any feedbacks? |
af8996b
to
96d7f7b
Compare
This is a gentle bump for the docs team that this PR is waiting for technical review. |
Hey @JacksonTian, thank you so much for writing this article and opening an PR to add it to our docs! ✨ Do you know if there is any Alibaba doc that can be cross referenced for GitHub OIDC integration? After checking with our engineering team, we are hoping to use this to internally verify an Alibaba set up. |
Hello @SiaraMist . The article https://www.alibabacloud.com/help/en/ram/user-guide/overview-of-oidc-based-sso describes how to use OIDC on Alibaba Cloud. And we have a GitHub Action https://github.com/aliyun/configure-aliyun-credentials-action to integrate with GitHub OIDC. Thanks for your feedback. |
This is a gentle bump for the docs team that this PR is waiting for technical review. |
Hey @JacksonTian, thank you so much for your patience as the team works through our backlog. 💛 I took your PR and the configuration documents you sent back to the team for review. They suggested that we add links to the Alibaba Cloud information from another article instead of adding this new one. I've gone ahead and opened a PR for that, and you can see the Alibaba Cloud mentions here and here. I'm going to close out this PR in favor of those changes. We really appreciate your thoughtful contribution to the GitHub docs. ✨ |
Why:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.