Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rudimentary gitlab support #657
base: master
Are you sure you want to change the base?
Added rudimentary gitlab support #657
Changes from all commits
736b772
c2e9ed9
7e6d1e2
468a7cb
df91ce2
8905121
4f24ec0
4ef2033
18ede11
86b41c0
2c261cb
e696d2c
16fdb8d
d1004f7
681c4b4
3b5a974
2a1350f
1de4431
d62e1e1
d6e257f
264e6ba
b13d759
b1f9d09
0e66b15
182ff69
602a923
81b1a9a
d5fa89b
faf358a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming here has issues:
merge_request
argument name - it can be a PR or a Merge Request (e.g.pr_or_merge_request
is not an ill-descriptive name for that)#try_merge_commit_sha_from_gitlab
obscures that it also processes GitHub dataA method name such as
#find_merge_commit_for(pr_or_merge_request)
would help maintenance of this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if
is an expression: this can be the whole body.