Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new hook to allow user to include a full view jumbotron to his pages #243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EricMaeker
Copy link

On landing pages only, add a hook to
jumbotron.txt (inside the namespace only)
Include this jumbotron content before the page to allow to create a full view jumbotron on landing pages.
See in action here: https://www.maeker.fr

Using a jumbotron.txt hook to make cleaner presentation.
See in action here: https://www.maeker.fr/
@EricMaeker
Copy link
Author

PS: this code needs the bootstrap plugin to include the jumbotron pull request I've sent some days earlier.

@giterlizzi
Copy link
Owner

giterlizzi commented Aug 20, 2016

Very interesting feature and awesome website!

I have a questions:

  • What is the version of templete and DokuWiki in your website ?
  • I dont see breadcrumbs and page icons. Are disabled ?

I have cloned your code and i have discovered the problems with jumbotron:

  • If you have a non-fixed navbar the jumbotron is displayed above the navbar
  • Is required to use an external plugin (jumbotron syntax)
  • Another problem is a visible padding if you have a container-fluid (recently fixed in dev branch)

I'm to work to integrate and test your patch (this and for bootswrapper).

Thanks a lot!
Joseph

@EricMaeker
Copy link
Author

Hello,

Thanks for your comments on my code and my website.
Next read inline.

I have a questions:

  • What is the version of templete and DokuWiki in your website ?

May be june 2016. I'm updating to the latest one actually. I'll ping you
when done.

  • I dont see breadcrumbs and page icons. Are disabled ?

Yes, I've removed them.
Also I've experimented problems with social providers icons. They are
not available on my interface... Not yet solved, even with the latest
template code.

I have cloned your code and i have discovered the problems with jumbotron:

  • If you have a non-fixed navbar the jumbotron is displayed above the
    navbar

Ok, may be include the hook after the navbar and before the
dokuwiki__content (to allow full screen).

  • Another problem is a visible padding if you have a container-fluid
    (recently fixed in dev branch)

At the top of the view ? Yes, I've patched your code inside
tpl_functions.php to remove the auto body padding-top inside function
bootstrap3_metaheaders(Doku_Event &$event, $param)

I'm to work to integrate and test your patch (this and for bootswrapper).

Thanks
Eric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants