Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed width that's lesser than the content width #472 #668

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ananyasingh2002
Copy link

The website's responsiveness was enhanced with "flex-wrap: wrap," and the layout adjustment at "@media (max-width: 993px)" ensures optimal display on various devices, creating a fully functional and user-friendly experience. Ensure code-blocks take-up fixed width that's lesser than the content width #472

@sivaraam
Copy link
Member

Hey @Ananyasingh2002 ! Thanks for the MR. Unfortunately, I believe this fix results in the whole page rendering with a smaller font size. This results in poor readability on mobile screens. Here's a couple of screenshots for reference:

Before After
Screenshot_2023-10-16-00-32-24-28_d0ef7a9810af20f7b394f4f927b723b0 Screenshot_2023-10-15-22-57-05-54_d0ef7a9810af20f7b394f4f927b723b0

Could you kindly look into how to avoid this and ensure the page renders well and just the code block is made scrollable as mentioned in the issue ?

@Ananyasingh2002
Copy link
Author

I'll do it by tomorrow.

@Ananyasingh2002
Copy link
Author

I have made changes to the font size, but there is an issue in the HTML code. Specifically, the list items under the 'Releases' header are not being affected by the font size increase. To address this, we need to add a class to the ul element immediately following the 'Releases' header.

@sivaraam
Copy link
Member

I have made changes to the font size, but there is an issue in the HTML code.

Could you not apply the font size change for the whole body rather than specific headings and paragraphs ? 🤔

With the recent change, not just the list items, many headings also appear strangely sized. Further, the font of code-block also seems to shrink on small screen sizes. It would be ideal if the code block was just scrollable without affecting the font size.

Checkout this screenshot for reference

Screenshot_2023-10-30-00-33-51-93_d0ef7a9810af20f7b394f4f927b723b0

Also, the current site's styling is such that it renders well on most screen sizes without the need to do a right-left scroll. Could you kindly check the feasibilty of achieving the same in your changes too ? Let us know if there's anything that hinders that.

@Ananyasingh2002
Copy link
Author

When we change the font size of the body, it only affects the font size of the navbar. Therefore, I need to adjust the font size of specific headings and paragraphs separately.

@Ananyasingh2002
Copy link
Author

Okay I'll do it.

@Ananyasingh2002
Copy link
Author

Could you please assist me by informing me about how to join the Git community for GSoC updates?

@chriscool
Copy link
Collaborator

@Ananyasingh2002 I think the best way to ask the community if you want GSoC updates is the Git mailing list (see https://git-scm.com/community). But the GSoC 2023 is over (see the first small article in https://git.github.io/rev_news/2023/09/30/edition-103/), and nothing is known yet about GSoC 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants