Bug in creating reference pointcloud for ICP registration #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug has been already highlighted and well explained in these two links. gisbi-kim#11 gisbi-kim#12 To check this - one can visualize the loop submap in RVIZ and can see the cluttered point cloud as it does not have correct registration.
The function is also changed in the author's latest code base https://github.com/gisbi-kim/lt-mapper/blob/bce4236d97bf0d9d97187f9355380e981ac7e499/ltslam/src/LTslam.cpp#L201 Basically loopFindNearKeyframesCloud function does not require the fourth input parameter that it initially had - it just creates more confusion and it never is used. Also while transforming the pointcloud to global coordinate frame (origin) and to accumulate surrounding frames, one does not need the fourth input parameter. Changed the function accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug has been already highlighted and well explained in these two links. #11
#12
To check this - one can visualize the loop submap in RVIZ and can see the cluttered point cloud as it does not have correct registration.