Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codecov): optimize configuration settings #3956

Closed
wants to merge 1 commit into from

Conversation

flc1125
Copy link
Contributor

@flc1125 flc1125 commented May 7, 2024

Fix:

image

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (3dc1cd6) to head (328960a).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3956      +/-   ##
==========================================
- Coverage   99.21%   99.18%   -0.03%     
==========================================
  Files          42       43       +1     
  Lines        3182     2716     -466     
==========================================
- Hits         3157     2694     -463     
+ Misses         17       12       -5     
- Partials        8       10       +2     
Flag Coverage Δ
?
-tags "sonic avx" 99.18% <ø> (?)
-tags go_json 99.18% <ø> (?)
-tags nomsgpack 99.17% <ø> (?)
go-1.18 99.11% <ø> (-0.01%) ⬇️
go-1.19 99.18% <ø> (-0.03%) ⬇️
go-1.20 99.18% <ø> (-0.03%) ⬇️
go-1.21 99.18% <ø> (-0.03%) ⬇️
go-1.22 99.18% <ø> (?)
macos-latest 99.18% <ø> (-0.03%) ⬇️
ubuntu-latest 99.18% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flc1125 flc1125 marked this pull request as draft May 7, 2024 13:57
@flc1125
Copy link
Contributor Author

flc1125 commented May 7, 2024

@appleboy Please set the token:

with:
  token: ${{ secrets.CODECOV_TOKEN }}

reference: https://github.com/codecov/codecov-action#usage

@appleboy
Copy link
Member

appleboy commented May 9, 2024

@flc1125 I am not the owner of the repository. Need @javierprovecho approval and update the secret setting. We just ignore the warning now.

@appleboy appleboy closed this May 9, 2024
@flc1125
Copy link
Contributor Author

flc1125 commented May 9, 2024

@flc1125 I am not the owner of the repository. Need @javierprovecho approval and update the secret setting. We just ignore the warning now.

OK, It's just that every time I see this, I'm a little obsessive about wanting to √

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants