fix some bugs that download response instead of showing result #6 #8
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 83.33% 83.78% +0.45%
==========================================
Files 1 1
Lines 36 37 +1
==========================================
+ Hits 30 31 +1
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
| @@ -34,7 +34,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/gin-contrib/gzip" | |||
| "github.com/gin-gonic/gin" | |||
| "github.com/gin-gonic/gin.v1" | |||
There was a problem hiding this comment.
This won't work, github.com/gin-gonic/gin is correct.
| @@ -8,7 +8,7 @@ import ( | |||
| "strings" | |||
| "sync" | |||
|
|
|||
| "github.com/gin-gonic/gin" | |||
| "gopkg.in/gin-gonic/gin.v1" | |||
There was a problem hiding this comment.
We are moving everything back to github.com/gin-gonic/gin in the time of dependency managers.
There was a problem hiding this comment.
so what happens if we use gin.v1 in our project ?
There was a problem hiding this comment.
You should replace it with github.com/gin-gonic/gin.
| @@ -37,6 +37,7 @@ func Gzip(level int) gin.HandlerFunc { | |||
| gz.Reset(c.Writer) | |||
|
|
|||
| c.Header("Content-Encoding", "gzip") | |||
| c.Header("Content-Type", "text/html; charset=UTF-8") | |||
There was a problem hiding this comment.
And how do you know that HTML should be returned?
There was a problem hiding this comment.
default content type is x-gizp and this encoding download the response html !
There was a problem hiding this comment.
But who say that you are using gzip only for html?
No description provided.