Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: duplicate column selection issue in getMany with joins and pagination #33

Closed
wants to merge 0 commits into from

Conversation

ZaidMaslouhi
Copy link

This pull request proposes a fix for the duplicate column names encountered when using getMany with joins and pagination in NestJS CRUD nestjsx#788.

The current solution in nestjsx#788 excludes the "id" column, which might not be ideal for all relational scenarios. This pull request aims to address duplication directly within the column array, preserving the "id" column when necessary or any duplicated column.

Key points:

Please review and provide feedback on the proposed approach.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8365400820

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.665%

Totals Coverage Status
Change from base Build 8258247547: 0.0%
Covered Lines: 1244
Relevant Lines: 1251

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants