Fix update cash balance #3193
Fix update cash balance #3193
Conversation
| @@ -57,7 +57,7 @@ export class AccountService { | |||
| > { | |||
| const { include = {}, skip, take, cursor, where, orderBy } = params; | |||
|
|
|||
| include.balances = { orderBy: { date: 'desc' }, take: 1 }; | |||
| include.balances = { orderBy: { createdAt: 'desc' }, take: 1 }; | |||
There was a problem hiding this comment.
This will not work if you have created a balance today for a previous day.
There was a problem hiding this comment.
What do you mean by creating a balance for today?
There was a problem hiding this comment.
In my opinion, cash balance table should only have one entry per account.
And use postgres capability on conflict to update the existing balance with the change.
There was a problem hiding this comment.
In my opinion, cash balance table should only have one entry per account.
No, we need multiple entries to show the progress of the account balance.
There was a problem hiding this comment.
So, when creating an account balance in the past, it needs to be inserted in order or be recalculated.
There was a problem hiding this comment.
No, I don't think so.
However, your comment leads me to the conclusion that the current implementation for update cash balance only works if the activity (e.g. interest) is today. In the GUI, the checkbox must be disabled if the date differs from today.
There was a problem hiding this comment.
They need to be newer than the last account balance date.
There was a problem hiding this comment.
I think the best approach is to insert on this table the balance change and use the a view to calculate the accumulated values based on the date.
I will do this change and fix this
There was a problem hiding this comment.
I will do this change and fix this
I have some doubts that it will work and would suggest to solely disable the checkbox based on the date.
No description provided.