tests : add non-cont unary tests #7857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
slaren
approved these changes
Jun 10, 2024
mofosyne
added
the
Review Complexity : Medium
ggerganov
force-pushed
the
gg/unary-non-cont
branch
from
b64daed
to
8412561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #7856
Unary op implementations on the GPU assume that
src0is contiguous, so we nowGGML_ASSERTthis in the backend codeThe CPU implementation actually supports
ggml_is_contiguous_1(src0)(i.e. elements within the rows are contiguous and dims 2, 3 are also contiguous, but there could be gaps between the rows). Maybe in the future the GPU backends can be extended to also support that, but for now theirsupport_opare updated to returnfalsein such cases