Updated server_queue to delete tasks from queue when server is shutdown. Feature Request #6421 #6941
+141
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based off tests made in req_cancelation_tests
rahsuri
changed the title
phymbert
added
the
demo
phymbert
requested changes
Apr 27, 2024
| @@ -29,6 +29,8 @@ | |||
| #include <thread> | |||
| #include <signal.h> | |||
| #include <memory> | |||
| #include <iostream> | |||
| #include <boost/asio.hpp> | |||
There was a problem hiding this comment.
Boost will never be required
| boost::system::error_code ec; | ||
|
|
||
| // Try to connect | ||
| connect(socket, resolver.resolve({server, port}), ec); |
There was a problem hiding this comment.
This is nonsense to inner call the server itself. You have everything needed inside the process.
|
Please don't use external heavy libraries like boost, #define CPPHTTPLIB_OPENSSL_SUPPORT
#include "path/to/httplib.h"
// HTTP
httplib::Client cli("http://cpp-httplib-server.yhirose.repl.co");
// HTTPS
httplib::Client cli("https://cpp-httplib-server.yhirose.repl.co");
auto res = cli.Get("/hi");
res->status;
res->body; |
mofosyne
added
the
review complexity : low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ive adding a server health checker that will periodically make sure the server is up and running when fetching requests, and cancels the request if the server is down. Please let me know if there are any changes I should make.
For: Feature Request: Task Cancellation on Client Disconnection #6421