Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: merge key for key groups #1493

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonasbadstuebner
Copy link

This closes #1123

The test is not very great (as in: "It doesn't check very much"), but since it was not too hard to implement, I think this is okay.

If you have any comments, please let me know.

closes getsops#1123

Signed-off-by: Jonas Badstübner <[email protected]>
@jonasbadstuebner
Copy link
Author

jonasbadstuebner commented Apr 23, 2024

Just so I have said it: This does not ensure that a key is included only once. Maybe this is a desirable feature when people start merging key_groups now?

But that is not any different from the overall key_groups behavior. And as far as I can tell, sops can handle it if there are multiple recipients matching. (I think it just takes the first matching one, I haven't checked this any futher)

@jonasbadstuebner
Copy link
Author

Should also mention:
Fixes #878

@jonasbadstuebner
Copy link
Author

Would be nice to get an ETA of when this will be looked at and maybe an ETA for a new patch release that includes this feature?

@jonasbadstuebner
Copy link
Author

@felixfontein Sorry to bother you again, but what is the current state of sops, it seems to be very slow moving and the last patch release has been a long time ago.

Why does a small MR like this take so much time to review and merge and when is the next patch release planned? 3.9.0 is on the road map for a very long time already, do you need help or is it something else?

@felixfontein
Copy link
Contributor

It seems that most maintainers currently have no time to review PRs. Since I don't want to merge PRs that I don't fully understand without a second review, this means that rarely any PRs get merged currently.

I was hoping for a soonish 3.9.0 release for some time already, I have no idea when it will happen.

@jonasbadstuebner
Copy link
Author

If you need maintainers, I would be happy to support sops. Who would be in charge of deciding this and what would I have to do?

@felixfontein
Copy link
Contributor

I'm not sure how the process works, but joining the #sops-dev channel on the CNCF Slack (https://github.com/getsops/sops/blob/main/CONTRIBUTING.md#communication, the second link allows you to get an invite for the CNCF Slack, and the former then allows you to join that channel) is probably a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants