Do not use DotEnv store for exec-env, but specialized environment serializing code #1436
+49
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids quoting problems, fixes getsops#784, and also better handles various problems that can arise, like '=' in keys and non-string keys and values. Signed-off-by: Felix Fontein <[email protected]>
felixfontein
force-pushed
the
exec-env
branch
from
c8ee97d
to
afe1a5b
Compare
|
Looks like I forgot to actually commit my latest changes yesterday 🤦 I've updated the PR. |
|
Does this also apply to exec-file as well? Was struggling with this when trying to load an encrypted file into GITHUB_ENV and curious if this will also fix that. |
|
|
Makes sense, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #784.
While looking at this I noticed that the DotEnv store does quite a few things that are bad, like assuming that all map keys are strings that do not contain
=, and that values are strings if they aren't complex. The code I added for environment serialization takes care of these issues, but the DotEnv code itself should also do that.Some of the DotEnv problems are fixed by #1401, so I didn't want to start changing that code as well.