chore: add rust code formatting check #1403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds rust code fromatting to the CI Signed-off-by: Shikhar Vashistha <[email protected]>
felixfontein
reviewed
Jan 2, 2024
This commit adds check flag to the formatting check Signed-off-by: Shikhar Vashistha <[email protected]>
|
The test looks good, though I'm not sure whether the placement is good. Right now it is run as part of the functional tests. I'm wondering whether we should create a new workflow for such linting-style tests. I think it won't hurt to add more static code checks in the future, like staticcheck. What do you think @getsops/maintainers? |
|
@felixfontein I agree that creating a separate workflow for linting would be preferable. I don't have a strong opinion whether it's done in this PR or a future one. @shikharvashistha thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds rust code formatting to the CI
closes #1397