Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

age-plugin support #1335

Closed
wants to merge 1 commit into from
Closed

age-plugin support #1335

wants to merge 1 commit into from

Conversation

Kranzes
Copy link

@Kranzes Kranzes commented Oct 30, 2023

Age recently exposed their plugins API as public which allows using it to add Age plugins support to Sops. With these changes which I have no written and don't understand I was able to get age plugins working in Sops. I'd like if someone that knows Go and the codebase continues these changes, as from what I understood a lot of them are just copied over from age itself (?).

@@ -5,7 +5,7 @@ go 1.19
require (
cloud.google.com/go/kms v1.15.3
cloud.google.com/go/storage v1.33.0
filippo.io/age v1.1.1
filippo.io/age v1.1.2-0.20230920124100-101cc8676386
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a new age release would be still a blocker for this, but review could already happen before that, so by the time we have an age update, this can be merged.

@Mic92
Copy link
Contributor

Mic92 commented Nov 1, 2023

You have to go through this process before anyone looks at your commit probably: https://github.com/getsops/sops/pull/1335/checks?check_run_id=18181524828

@Kranzes
Copy link
Author

Kranzes commented Nov 1, 2023

You have to go through this process before anyone looks at your commit probably: https://github.com/getsops/sops/pull/1335/checks?check_run_id=18181524828

Check again if I did it correctly

@Mic92
Copy link
Contributor

Mic92 commented Nov 1, 2023

You have to go through this process before anyone looks at your commit probably: https://github.com/getsops/sops/pull/1335/checks?check_run_id=18181524828

Check again if I did it correctly

Looks better now.

Signed-off-by: Jörg Thalheim <[email protected]>
@patryk4815
Copy link

patryk4815 commented Feb 19, 2024

Hi.
If someone install "https://github.com/remko/age-plugin-se" and use it only on macos it is fine.

But then i want do something on linux:

$ sops updatekeys ./secrets-db.yaml

error updating one or more master keys: 
  [failed to encrypt new data key with master key "age1se1qd0ljv856qg8chyesxdqw04n9fatp9qwvng6kkzwahr700rjqrq4gh99vdr": 
    failed to create writer for encrypting sops data key with age: 
      failed to wrap key for recipient #0: 
        se plugin: couldn't start plugin: exec: "age-plugin-se": 
          executable file not found in $PATH]

age-plugin-se - is only for macos. Not possible to install on linux!

Soo this error blocks me from adding the newkey (standard/classic age key) from Linux.

@Kranzes
Copy link
Author

Kranzes commented Feb 19, 2024

Honestly, I am kinda interested in rops more right now and I think I will implement or help implement age-plugin support for it. Don't expect me to continue working on this PR, I don't know Go.

@patryk4815
Copy link

@Kranzes same issue can happen there :)

@Kranzes
Copy link
Author

Kranzes commented Feb 19, 2024

@Kranzes same issue can happen there :)

Your problem stems from the Go code written as part of this PR, it is not inherent to age plugin support for sops/rops, right?

@Mic92 Mic92 mentioned this pull request Mar 18, 2024
@Mic92
Copy link
Contributor

Mic92 commented Mar 18, 2024

I rebased this pull request in #1465
Since @Kranzes doesn't have any places to work further on this, we can close this pull request.

@Kranzes Kranzes closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants