Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(routes): Avoid usage of optional route params #70631

Conversation

evanpurkhiser
Copy link
Member

The syntax has changed in react-router 6. Instead of trying to build
compatability we can just remove the one optional route we have.

@evanpurkhiser evanpurkhiser requested a review from a team May 9, 2024 23:44
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 9, 2024
The syntax has changed in react-router 6. Instead of trying to build
compatability we can just remove the one optional route we have.
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-routes-avoid-usage-of-optional-route-params branch from 2cb60c4 to f99ceb2 Compare May 10, 2024 14:18
@evanpurkhiser evanpurkhiser merged commit b6ef805 into master May 10, 2024
42 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-routes-avoid-usage-of-optional-route-params branch May 10, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants