Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Upgrade rrweb packages to 2.16.0 #12036

Closed
wants to merge 2 commits into from

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented May 14, 2024

Pulls in rest of upstream rrweb patches up to rrweb-io/rrweb@ae6908d

See getsentry/rrweb#189

Copy link
Contributor

github-actions bot commented May 14, 2024

size-limit report 📦

Path Size
@sentry/browser 21.74 KB (0%)
@sentry/browser (incl. Tracing) 32.88 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) 68.39 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.82 KB (+0.26% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.43 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.49 KB (+0.19% 🔺)
@sentry/browser (incl. Feedback) 37.75 KB (0%)
@sentry/browser (incl. sendFeedback) 26.31 KB (+0.01% 🔺)
@sentry/browser (incl. FeedbackAsync) 30.73 KB (0%)
@sentry/react 24.43 KB (0%)
@sentry/react (incl. Tracing) 35.88 KB (0%)
@sentry/vue 25.68 KB (0%)
@sentry/vue (incl. Tracing) 34.7 KB (0%)
@sentry/svelte 21.88 KB (0%)
CDN Bundle 24.26 KB (0%)
CDN Bundle (incl. Tracing) 34.33 KB (0%)
CDN Bundle (incl. Tracing, Replay) 68.17 KB (+0.23% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 73.17 KB (+0.22% 🔺)
CDN Bundle - uncompressed 71.39 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101.81 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 211.91 KB (+0.23% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 224.27 KB (+0.22% 🔺)
@sentry/nextjs (client) 35.14 KB (0%)
@sentry/sveltekit (client) 33.48 KB (0%)
@sentry/node 114.1 KB (0%)
@sentry/aws-serverless 103 KB (+0.01% 🔺)

@billyvg
Copy link
Member Author

billyvg commented May 14, 2024

Still needs some manual testing but wanted to see if browser tests pass.

@billyvg billyvg force-pushed the feat-replay-upgrade-rrweb-2.16 branch 2 times, most recently from 626afad to a33ac5e Compare May 22, 2024 14:30
@billyvg
Copy link
Member Author

billyvg commented May 22, 2024

Had to increase size limit budget because the @sentry/browser (incl. Tracing, Replay) increased from 69899 bytes to 70033 bytes (limit was 70000).

@billyvg billyvg force-pushed the feat-replay-upgrade-rrweb-2.16 branch from 9fdf6c1 to ae1b741 Compare May 22, 2024 18:20
@billyvg billyvg marked this pull request as ready for review May 22, 2024 22:00
@billyvg billyvg requested a review from a team as a code owner May 22, 2024 22:00
@billyvg
Copy link
Member Author

billyvg commented May 29, 2024

Holding off on upgrading to 2.16.0 due to some potential perf issues

@billyvg billyvg closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant